Skip to content

Remove old set of deps test#2976

Merged
maleadt merged 3 commits into
masterfrom
ksh/old
Nov 18, 2025
Merged

Remove old set of deps test#2976
maleadt merged 3 commits into
masterfrom
ksh/old

Conversation

@kshyatt

@kshyatt kshyatt commented Nov 18, 2025

Copy link
Copy Markdown
Member

This is completely blocking CI yet only appears on the old dependency test. No one has opened an issue about it, suggesting it's not affecting users (yet...). Until/unless someone runs up a flag, should we let this soft fail for now?

@kshyatt kshyatt requested a review from maleadt November 18, 2025 06:17
@kshyatt kshyatt added the ci Everything related to continuous integration. label Nov 18, 2025

@maleadt maleadt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The run is there for a reason. If we can't fix it, I'd rather remove it than add yet another soft-fail.

Can you reproduce locally? Have you tried bumping compat bounds to see which upgrade causes the issue?

@kshyatt

kshyatt commented Nov 18, 2025

Copy link
Copy Markdown
Member Author

I'll try to repro locally again, Resolver wasn't working for me earlier but today is a new day :)

@codecov

codecov Bot commented Nov 18, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.36%. Comparing base (dc13bbc) to head (58c8201).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2976       +/-   ##
===========================================
- Coverage   89.51%   76.36%   -13.15%     
===========================================
  Files         150      147        -3     
  Lines       13115    13054       -61     
===========================================
- Hits        11740     9969     -1771     
- Misses       1375     3085     +1710     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CUDA.jl Benchmarks

Details
Benchmark suite Current: 0912e84 Previous: bb7bc44 Ratio
latency/precompile 56881685517 ns 57053937298.5 ns 1.00
latency/ttfp 8312996055 ns 8313449149.5 ns 1.00
latency/import 4495003446 ns 4495227234 ns 1.00
integration/volumerhs 9621138.5 ns 9609731 ns 1.00
integration/byval/slices=1 146741 ns 146771 ns 1.00
integration/byval/slices=3 425722 ns 425865 ns 1.00
integration/byval/reference 144934 ns 145205 ns 1.00
integration/byval/slices=2 286100 ns 286334 ns 1.00
integration/cudadevrt 103430.5 ns 103543 ns 1.00
kernel/indexing 14099 ns 14174 ns 0.99
kernel/indexing_checked 14926.5 ns 14879 ns 1.00
kernel/occupancy 667.6835443037975 ns 670.9177215189874 ns 1.00
kernel/launch 2147.1111111111113 ns 2111.8 ns 1.02
kernel/rand 16854 ns 15193 ns 1.11
array/reverse/1d 19866 ns 20290 ns 0.98
array/reverse/2dL_inplace 66835 ns 66861 ns 1.00
array/reverse/1dL 69888 ns 70337 ns 0.99
array/reverse/2d 21700.5 ns 22210 ns 0.98
array/reverse/1d_inplace 9615 ns 9641 ns 1.00
array/reverse/2d_inplace 11040 ns 13386 ns 0.82
array/reverse/2dL 73731 ns 74283 ns 0.99
array/reverse/1dL_inplace 66775 ns 66783 ns 1.00
array/copy 20501 ns 20919 ns 0.98
array/iteration/findall/int 157376 ns 158654 ns 0.99
array/iteration/findall/bool 139913 ns 140615 ns 1.00
array/iteration/findfirst/int 161013.5 ns 161604.5 ns 1.00
array/iteration/findfirst/bool 161560 ns 162505 ns 0.99
array/iteration/scalar 72537 ns 74607 ns 0.97
array/iteration/logical 215397.5 ns 218146 ns 0.99
array/iteration/findmin/1d 50476 ns 53029 ns 0.95
array/iteration/findmin/2d 95991 ns 96965 ns 0.99
array/reductions/reduce/Int64/1d 42979 ns 43857 ns 0.98
array/reductions/reduce/Int64/dims=1 44270.5 ns 44929 ns 0.99
array/reductions/reduce/Int64/dims=2 61191 ns 61783 ns 0.99
array/reductions/reduce/Int64/dims=1L 88608 ns 89162 ns 0.99
array/reductions/reduce/Int64/dims=2L 87178 ns 88307 ns 0.99
array/reductions/reduce/Float32/1d 36628 ns 37230 ns 0.98
array/reductions/reduce/Float32/dims=1 41292 ns 50726 ns 0.81
array/reductions/reduce/Float32/dims=2 59483 ns 60284 ns 0.99
array/reductions/reduce/Float32/dims=1L 52134 ns 52649 ns 0.99
array/reductions/reduce/Float32/dims=2L 71764 ns 72742 ns 0.99
array/reductions/mapreduce/Int64/1d 43194 ns 43667 ns 0.99
array/reductions/mapreduce/Int64/dims=1 52570 ns 44472 ns 1.18
array/reductions/mapreduce/Int64/dims=2 61302 ns 61760 ns 0.99
array/reductions/mapreduce/Int64/dims=1L 88664 ns 89084 ns 1.00
array/reductions/mapreduce/Int64/dims=2L 87330 ns 88448.5 ns 0.99
array/reductions/mapreduce/Float32/1d 37369 ns 37214 ns 1.00
array/reductions/mapreduce/Float32/dims=1 42147 ns 43130 ns 0.98
array/reductions/mapreduce/Float32/dims=2 59642 ns 60025 ns 0.99
array/reductions/mapreduce/Float32/dims=1L 52392 ns 52879 ns 0.99
array/reductions/mapreduce/Float32/dims=2L 71859 ns 72506 ns 0.99
array/broadcast 19672 ns 20173 ns 0.98
array/copyto!/gpu_to_gpu 11201 ns 11263 ns 0.99
array/copyto!/cpu_to_gpu 214350.5 ns 216321 ns 0.99
array/copyto!/gpu_to_cpu 282014.5 ns 283906 ns 0.99
array/accumulate/Int64/1d 124988.5 ns 125185 ns 1.00
array/accumulate/Int64/dims=1 83113.5 ns 83290 ns 1.00
array/accumulate/Int64/dims=2 157392 ns 157793 ns 1.00
array/accumulate/Int64/dims=1L 1709631 ns 1709512 ns 1.00
array/accumulate/Int64/dims=2L 966152.5 ns 966574.5 ns 1.00
array/accumulate/Float32/1d 108667 ns 109309 ns 0.99
array/accumulate/Float32/dims=1 80256 ns 80361 ns 1.00
array/accumulate/Float32/dims=2 147013 ns 147589 ns 1.00
array/accumulate/Float32/dims=1L 1619035.5 ns 1618990 ns 1.00
array/accumulate/Float32/dims=2L 697778 ns 698423 ns 1.00
array/construct 1240 ns 1284 ns 0.97
array/random/randn/Float32 48189 ns 48672 ns 0.99
array/random/randn!/Float32 24953 ns 25210 ns 0.99
array/random/rand!/Int64 27212 ns 27299 ns 1.00
array/random/rand!/Float32 8728 ns 8794.333333333334 ns 0.99
array/random/rand/Int64 29584 ns 30095 ns 0.98
array/random/rand/Float32 12950 ns 13270 ns 0.98
array/permutedims/4d 54823 ns 55523.5 ns 0.99
array/permutedims/2d 53429 ns 54033.5 ns 0.99
array/permutedims/3d 54424.5 ns 55090.5 ns 0.99
array/sorting/1d 2757692 ns 2758035 ns 1.00
array/sorting/by 3343869.5 ns 3344921 ns 1.00
array/sorting/2d 1081031.5 ns 1081700.5 ns 1.00
cuda/synchronization/stream/auto 1049.9 ns 1021.1 ns 1.03
cuda/synchronization/stream/nonblocking 8295 ns 7536.4 ns 1.10
cuda/synchronization/stream/blocking 810.8695652173913 ns 790.5204081632653 ns 1.03
cuda/synchronization/context/auto 1184.5 ns 1172.4 ns 1.01
cuda/synchronization/context/nonblocking 8370.3 ns 8350.5 ns 1.00
cuda/synchronization/context/blocking 906.6818181818181 ns 899.8913043478261 ns 1.01

This comment was automatically generated by workflow using github-action-benchmark.

@kshyatt

kshyatt commented Nov 18, 2025

Copy link
Copy Markdown
Member Author

Couldn't repro locally but discussed on Slack that this specific base/threading set of tests is known to be flaky (see comment at the top of the file) so it may make sense to disable it for now

@kshyatt kshyatt requested a review from maleadt November 18, 2025 14:59
@kshyatt kshyatt changed the title Allow old set of deps to soft fail? Remove old set of deps test Nov 18, 2025
@maleadt maleadt merged commit 69b8817 into master Nov 18, 2025
2 checks passed
@maleadt maleadt deleted the ksh/old branch November 18, 2025 15:41
maleadt added a commit that referenced this pull request Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Everything related to continuous integration.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants