Skip to content

Support mul!(Diagonal, A, B) #2977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maleadt merged 1 commit into from
Nov 19, 2025
Merged

Support mul!(Diagonal, A, B) #2977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/cublas/linalg.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,6 +537,12 @@ function LinearAlgebra.mul!(C::CuMatrix{T}, A::Diagonal{T,<:CuVector}, B::Adjoin
return C
end

function LinearAlgebra.mul!(C::Diagonal{T, <:CuVector}, A::Union{<:CuMatrix{T}, Adjoint{T, <:CuMatrix}, Transpose{T, <:CuMatrix}}, B::Union{<:CuMatrix{T}, Adjoint{T, <:CuMatrix}, Transpose{T, <:CuMatrix}}) where {T<:CublasFloat}
Cfull = A*B
C.diag .= diag(Cfull)
return C
end

function LinearAlgebra.lmul!(A::Diagonal{T,<:CuVector{T}}, B::CuMatrix{T}) where {T<:CublasFloat}
return dgmm!('L', B, A.diag, B)
end
Expand Down
9 changes: 9 additions & 0 deletions test/libraries/cublas/extensions.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,6 +585,15 @@ k = 13
@test Array(d_AX) ≈ A' * Diagonal(x)

@test Array(d_X) == Diagonal(Array(d_x))

d_X = Diagonal(copy(d_x))
diagA = diagm(rand(elty, m))
d_diagA = CuArray(diagA)
diagB = diagm(rand(elty, m))
d_diagB = CuArray(diagB)
diagAdiagB = diagA * diagB'
mul!(d_X, d_diagA, d_diagB')
@test Diagonal(collect(d_X.diag)) ≈ Diagonal(diagAdiagB)
end
end # extensions

Expand Down