Skip to content

Refactor and make HealthLLM.jl more modular and easy to use#21

Open
ParamThakkar123 wants to merge 7 commits intomainfrom
refactor
Open

Refactor and make HealthLLM.jl more modular and easy to use#21
ParamThakkar123 wants to merge 7 commits intomainfrom
refactor

Conversation

@ParamThakkar123
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Member

@TheCedarPrince TheCedarPrince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the conversation going here.

Comment on lines +53 to +57
"""
register_models(model_name, model_embedding; schema=PromptingTools.OllamaSchema())

Register chat and embedding models in PromptingTools and set them as active defaults.
"""
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing documentation for the arguments and keyword arguments and returns as well as example.

Comment on lines +30 to +34
write_combined_file(files, output_file)

Concatenate the provided text files into a single output file and include
a `# File: <path>` header before each file body.
"""
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing documentation for the arguments and keyword arguments and returns as well as example.

Comment on lines +5 to +10
"""
collect_files_with_extensions(directory, extensions)

Recursively collect file paths under `directory` whose extension is in `extensions`.
Extensions are matched case-insensitively (e.g. `".jl"`).
"""
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing documentation for the arguments and keyword arguments and returns as well as example.

Comment on lines -3 to -8
using PromptingTools
using RAGTools
using LinearAlgebra
using SparseArrays
using JSON3, Serialization
using Statistics
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this got deleted?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the tests are unable to run; I get this error when trying test within the Julia REPL:

(JuliaHealthLLM) pkg> test
┌ Warning: The project dependencies or compat requirements have changed since the manifest was last resolv
ed.
│ It is recommended to `Pkg.resolve()` or consider `Pkg.update()` if necessary.
ERROR: Package JuliaHealthLLM did not provide a `test/runtests.jl` file

Comment on lines +21 to +24
using HealthLLM

files = collect_files_with_extensions("data", [".md", ".jl"])
combined = write_combined_file(files, "combined.txt")
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would still like to see the full Gemini demo, but are you imagining a usage like this:

using HealthLLM

files = collect_files_with_extensions("data", [".md", ".jl"])
combined = write_combined_file(files, "combined.txt")

# How to build embeddings
# How to validate embeddings
# How to store the embeddings
# How to retrieve the embeddings per query
# How to query the RAG system
# How to use the RAG response for a database query

I am having trouble to wrap my head around the usage here without the code here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants