Skip GPU excitation relaxation for infinite T1 and T2 - #919
Open
KookiesNKareem wants to merge 3 commits into
Open
Skip GPU excitation relaxation for infinite T1 and T2#919KookiesNKareem wants to merge 3 commits into
KookiesNKareem wants to merge 3 commits into
Conversation
Member
|
Actually we might be able to make it even faster for the excitation kernel. For the non-relaxation case, the excitation is equivalent to Spinor reduction. So we don't need repeated rotations of |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #919 +/- ##
==========================================
- Coverage 91.83% 91.78% -0.06%
==========================================
Files 137 137
Lines 7188 7192 +4
==========================================
Hits 6601 6601
- Misses 587 591 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Valtype parameterWhy
For infinite T1 and T2, E1 and E2 are exactly one. The GPU excitation kernel was still loading relaxation data and evaluating two exponentials for every spin and time step. Encoding the condition in the kernel type gives the GPU compiler separate finite- and infinite-relaxation kernels while keeping a single kernel implementation.
Finite-relaxation behavior is unchanged.
Validation
Pkg.test("KomaMRICore"): 432/432 passedgit diff --checkThe
run-gpu-cilabel is attached for CUDA coverage.