Skip to content

extract: use open(create=true) when extracting files#148

Open
StefanKarpinski wants to merge 1 commit into
masterfrom
sk/open-create
Open

extract: use open(create=true) when extracting files#148
StefanKarpinski wants to merge 1 commit into
masterfrom
sk/open-create

Conversation

@StefanKarpinski

@StefanKarpinski StefanKarpinski commented Oct 25, 2022

Copy link
Copy Markdown
Member

Using open's create flag when extracting files should prevent certain kinds of attacks if all our other defenses don't catch them, e.g. writing CON on Windows or /etc/passwd on UNIX. Closes #147.

@StefanKarpinski

Copy link
Copy Markdown
Member Author

@vtjnash, is this what you had in mind?

@codecov

codecov Bot commented Oct 25, 2022

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.37%. Comparing base (6bfc114) to head (0dc24db).
⚠️ Report is 36 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #148   +/-   ##
=======================================
  Coverage   97.37%   97.37%           
=======================================
  Files           4        4           
  Lines         801      801           
=======================================
  Hits          780      780           
  Misses         21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

security improvement: open files with O_EXCL for writing

1 participant