The current code has a bounds safety issue that could cause a BoundsError#76
Closed
dronabopche wants to merge 1 commit intoJuliaLang:mainfrom
Closed
The current code has a bounds safety issue that could cause a BoundsError#76dronabopche wants to merge 1 commit intoJuliaLang:mainfrom
dronabopche wants to merge 1 commit intoJuliaLang:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
=======================================
Coverage 82.47% 82.47%
=======================================
Files 3 3
Lines 97 97
=======================================
Hits 80 80
Misses 17 17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem : The current code has a bounds safety issue that could cause a BoundsError
example : when reached
i = lastindextag stores vallastindex+1that can cause problemChange
Current code Is:
change i DID:
can Do this if wanted an error log
at the end of the loop, if
i <= ilast, you can throw a clearer error: