Skip to content

[JuliaLowering] Fix identifier -> GlobalRef conversion#61521

Merged
IanButterworth merged 1 commit intoJuliaLang:masterfrom
topolarity:ct/fix-JL-gr-compat
Apr 8, 2026
Merged

[JuliaLowering] Fix identifier -> GlobalRef conversion#61521
IanButterworth merged 1 commit intoJuliaLang:masterfrom
topolarity:ct/fix-JL-gr-compat

Conversation

@topolarity
Copy link
Copy Markdown
Member

@topolarity topolarity commented Apr 7, 2026

This fixes the @invokelatest macro.

This is a somewhat blind fix without understanding the broader structure of compat.jl, so let me know if I'm in the wrong direction @mlechu. Resolves JuliaLang/JuliaLowering.jl#174.

@topolarity topolarity requested a review from mlechu April 7, 2026 14:39
@topolarity topolarity added bugfix This change fixes an existing bug JuliaLowering labels Apr 7, 2026
@topolarity topolarity force-pushed the ct/fix-JL-gr-compat branch from eec0621 to 7aed4c2 Compare April 7, 2026 18:01
Copy link
Copy Markdown
Member

@mlechu mlechu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

This fixes the `@invokelatest` macro, which is arguably very pervasive
but somehow not exercised in any stdlib tests.
@topolarity topolarity force-pushed the ct/fix-JL-gr-compat branch from 7aed4c2 to de008ce Compare April 7, 2026 21:16
@topolarity topolarity added the merge me PR is reviewed. Merge when all tests are passing label Apr 7, 2026
@IanButterworth IanButterworth merged commit 6c244b8 into JuliaLang:master Apr 8, 2026
8 of 9 checks passed
@IanButterworth IanButterworth removed the merge me PR is reviewed. Merge when all tests are passing label Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix This change fixes an existing bug JuliaLowering

Projects

None yet

Development

Successfully merging this pull request may close these issues.

QuoteNode(::GlobalRef) becomes Symbol during macro-expansion

3 participants