Add a ManifoldsBaseMakie extension#272
Conversation
uses Preferences.jl for a persistent state.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #272 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 33 34 +1
Lines 3771 3802 +31
=========================================
+ Hits 3771 3802 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Judging by the error I think we need to use CairoMakie on CI instead of GLMakie. |
…verwritten” warnings
|
Nice, the concept and the test ideas even work. The remaining 4 lines are currently impossible to cover, since that method is overwritten (actually by both the Plots and the combined extension) which causes warnings anyways, so I have to change that a bit; |
|
Uff, this is quite tricky to get right, that loading a plotting package it “just works” we do not have exponential growth in extensions and we do not overwrite existing methods. Somewhere I might still have a quadruple knot in my thoughts by now. But I tried for several hours to get it right. Ah. Changing variables within therein package from the extension does not have a persistent effect, it is basically not set. Interesting to know. |
…h extension is already loaded.
so that the checks, e.g. for retractions or geodesics – or the gradient in Manopt, can also be done with Makie instead of Plots.