Switch to using Runic.jl as code formatter.#493
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #493 +/- ##
=======================================
Coverage 99.80% 99.80%
=======================================
Files 85 85
Lines 9372 9375 +3
=======================================
+ Hits 9354 9357 +3
Misses 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I think the Runic.jl-formatted code looks fine, and Runic might be a more future-proof solution than staying with JuliaFormatter v1 or hoping JuliaFormatter v2 is correct now. |
|
Thanks for checking. Yeah I am not sure how far JuliaFormatter v2 is, maybe the only disadvantage of Runic is, that there is a bit of setup compared to JuliaFormatter which works “out-of-the-box” with VS code. |
|
I actually always run JuliaFormatter from REPL because I wasn't sure the VSCode integration does the right thing, so that's not a problem for me. As long as formatting is one REPL command, I'm fine (I just grab it from REPL history). |
|
Nice, I actually did that for most of the time as well, sometimes using the shortcut to format the current file, but hat we also have with runic. And runic also has a bash command that one can easily set up :) Then we could probably really switch to runic. Nice! |
# Conflicts: # src/plans/stepsize.jl # src/solvers/gradient_descent.jl
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…s/Manopt.jl into kellertuer/switch-to-runic
# Conflicts: # .github/workflows/format.yml # ext/ManoptJuMPExt.jl # src/documentation_glossary.jl # src/plans/conjugate_gradient_plan.jl # src/plans/debug.jl # src/plans/first_order_plan.jl # src/plans/frank_wolfe_plan.jl # src/plans/trust_regions_plan.jl # src/solvers/FrankWolfe.jl # src/solvers/conjugate_gradient_descent.jl # src/solvers/interior_point_Newton.jl
Inspired by the short JuliaCon talk, this tests out how Runic would format Manopt and whether the CI would work.