Skip to content

Switch to using Runic.jl as code formatter.#493

Merged
kellertuer merged 15 commits into
masterfrom
kellertuer/switch-to-runic
Sep 5, 2025
Merged

Switch to using Runic.jl as code formatter.#493
kellertuer merged 15 commits into
masterfrom
kellertuer/switch-to-runic

Conversation

@kellertuer

Copy link
Copy Markdown
Member

Inspired by the short JuliaCon talk, this tests out how Runic would format Manopt and whether the CI would work.

@codecov

codecov Bot commented Jul 24, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.80%. Comparing base (feccfaa) to head (576b912).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #493   +/-   ##
=======================================
  Coverage   99.80%   99.80%           
=======================================
  Files          85       85           
  Lines        9372     9375    +3     
=======================================
+ Hits         9354     9357    +3     
  Misses         18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mateuszbaran

Copy link
Copy Markdown
Member

I think the Runic.jl-formatted code looks fine, and Runic might be a more future-proof solution than staying with JuliaFormatter v1 or hoping JuliaFormatter v2 is correct now.

@kellertuer

Copy link
Copy Markdown
Member Author

Thanks for checking. Yeah I am not sure how far JuliaFormatter v2 is, maybe the only disadvantage of Runic is, that there is a bit of setup compared to JuliaFormatter which works “out-of-the-box” with VS code.

@mateuszbaran

Copy link
Copy Markdown
Member

I actually always run JuliaFormatter from REPL because I wasn't sure the VSCode integration does the right thing, so that's not a problem for me. As long as formatting is one REPL command, I'm fine (I just grab it from REPL history).

@kellertuer

Copy link
Copy Markdown
Member Author

Nice, I actually did that for most of the time as well, sometimes using the shortcut to format the current file, but hat we also have with runic. And runic also has a bash command that one can easily set up :)

Then we could probably really switch to runic. Nice!

@kellertuer kellertuer changed the title [Test] Switching to runic as a formatter Switch to using Runic.jl as code formatter. Jul 25, 2025
kellertuer and others added 6 commits July 30, 2025 14:09
# Conflicts:
#	src/plans/stepsize.jl
#	src/solvers/gradient_descent.jl
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
# Conflicts:
#	.github/workflows/format.yml
#	ext/ManoptJuMPExt.jl
#	src/documentation_glossary.jl
#	src/plans/conjugate_gradient_plan.jl
#	src/plans/debug.jl
#	src/plans/first_order_plan.jl
#	src/plans/frank_wolfe_plan.jl
#	src/plans/trust_regions_plan.jl
#	src/solvers/FrankWolfe.jl
#	src/solvers/conjugate_gradient_descent.jl
#	src/solvers/interior_point_Newton.jl
@kellertuer
kellertuer merged commit a364659 into master Sep 5, 2025
15 checks passed
@kellertuer
kellertuer deleted the kellertuer/switch-to-runic branch February 13, 2026 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants