Skip to content

Don't print debug actions when k=-1 #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kellertuer merged 6 commits into from
Jun 3, 2026
+12 −7
Merged

Don't print debug actions when k=-1 #609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a5e9098
don't print DebugTime when k=-1
JoshuaLampert Jun 2, 2026
2e24c4b
add k < 0 guards to remaining DebugActions
JoshuaLampert Jun 2, 2026
6e0a8e0
add changelog entry
JoshuaLampert Jun 2, 2026
855414f
warning should warn also when k < 0
JoshuaLampert Jun 2, 2026
35dc2c5
update Changelog
JoshuaLampert Jun 3, 2026
b8f71a0
Update Changelog.md
JoshuaLampert Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@ The file was started with Version `0.4`.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.5.39] June 3, 2026

### Fixed

* a small bug where debug statements were printed even though they should not be due to `DebugEvery` and unified warnings to print independent of `DebugEvery`. (#609)

## [0.5.38] May 19, 2026

### Changed
Expand Down
13 changes: 6 additions & 7 deletions src/plans/debug.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,7 +614,7 @@ function (d::DebugEntryChange)(
end
x = get_storage(d.storage, d.field)
v = d.distance(p, st, getproperty(st, d.field), x)
Printf.format(d.io, Printf.Format(d.format), v)
(k > 0) && Printf.format(d.io, Printf.Format(d.format), v)
d.storage(p, st, k)
return nothing
end
Expand Down Expand Up @@ -939,15 +939,15 @@ end
function (d::DebugTime)(::AbstractManoptProblem, ::AbstractManoptSolverState, k)
if k == 0 || d.last_time == Nanosecond(0) # init
d.last_time = Nanosecond(time_ns())
else
elseif k > 0
t = time_ns()
p = Nanosecond(t) - d.last_time
Printf.format(
d.io, Printf.Format(d.format), canonicalize(round(p, d.time_accuracy))
)
end
if d.mode == :iterative
d.last_time = Nanosecond(time_ns())
if d.mode == :iterative
d.last_time = Nanosecond(time_ns())
end
end
return nothing
end
Expand Down Expand Up @@ -1011,7 +1011,6 @@ end
function (d::DebugWarnIfCostIncreases)(
p::AbstractManoptProblem, st::AbstractManoptSolverState, k::Int
)
(k < 0) && (return nothing)
if d.status !== :No
cost = get_cost(p, get_iterate(st))
if cost > d.old_cost + d.tol
Expand Down Expand Up @@ -1219,7 +1218,7 @@ end
function (d::DebugWarnIfStepsizeCollapsed)(
amp::AbstractManoptProblem, st::AbstractManoptSolverState, k::Int
)
(k < 1) && (return nothing)
(k == 0) && (return nothing)
if d.status !== :No
if get_last_stepsize(amp, st, k) ≤ d.stop_when_stepsize_less
@warn "Backtracking stopped because the stepsize fell below the threshold $(d.stop_when_stepsize_less)."
Expand Down
Loading