Skip to content

fix links in documentation#614

Merged
kellertuer merged 4 commits into
JuliaManifolds:masterfrom
araujoms:doclinks
Jun 9, 2026
Merged

fix links in documentation#614
kellertuer merged 4 commits into
JuliaManifolds:masterfrom
araujoms:doclinks

Conversation

@araujoms

@araujoms araujoms commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@kellertuer

kellertuer commented Jun 9, 2026

Copy link
Copy Markdown
Member

Thanks!
Since the Quarto Markdowns render into Markdown (inside the docs) and we have DocumenterInterlinks therein, we could even move them to extrefs by now. That is a bit tricky, since the “link” part of the [a](b) format has to be saved a bit then :)

edit: of the full detail – you have to write something like ``[`A`](@extef `B`)``{=commonkmark} to tell quarto to not escape the space in the “link” to a %20.
That is quite technical, but at least we have a way to actually use ext links in our docs ;)

But I just note that down and do that on the next version (see the #605 preparation PR).

@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (19fc393) to head (9e046b9).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #614   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           91        91           
  Lines        10054     10054           
=========================================
  Hits         10054     10054           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kellertuer

Copy link
Copy Markdown
Member

(do not worry about the nightly error – feel free to add a Changelog entry referring to this PR if you like!)

@araujoms

araujoms commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

Das kommt mir spanisch vor, ich überlasse es dir. Einen Eintrag im Changelog kann ich schon hinzufügen.

@kellertuer

Copy link
Copy Markdown
Member

Das ist aber tatsächlich englisch :D (Wieso schreiben wir auf deutsch?)

Kein Problem war auch nur eine Idee – dank deines PRs hier hab ich die alle jetzt im Blick und Überarbeite sie dann auf dem branch an dem wir aktuell sitzen.
Also auch so super, dass du die Fehler meldest und fixt! Den Rest mach ich dann gern.

Comment thread Changelog.md Outdated
@araujoms

araujoms commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

Das freut mich. Ich habe nur gedacht, mit so einem Benutzernamen muss du Deutsch sprechen. Es ist mir lieber als Englisch.

@kellertuer

Copy link
Copy Markdown
Member

Gut erkannt! Vi kan også skrive på norsk! Aber bei Spanisch habe ich keine Chance!

Sobald man öffentliche Diskussionen führt, schreibe ich meistens auf Englisch, weil es mehr Leute einschliesst.

Danke für den PR, Ich merge den, sobald die Tests nochmal durchgelaufen sind. Da ich eh gerade an der Dokumentation arbeite, werde ich das gleich auch einmal auf das neue Format umschreiben. Mit DocumenterInterlinks ist das wirklich sehr nett.

@kellertuer
kellertuer merged commit 3aab19e into JuliaManifolds:master Jun 9, 2026
12 of 15 checks passed
@kellertuer

Copy link
Copy Markdown
Member

Here is the commit that continues this

6834f17

It

  • replaces the ones from here and a few more https:// links by proper ref and extref links in the docs
  • as long as they are refs these work the same way in the tutorials
  • as soon as they are extrefs, they have a in there and the {=commonmark} magic is used.

Thanks for the pointer to this. Now all these links are “aotmatically” used (ref) or looked up in the inventory of the other docs (extref) and hence much more reliable :)

@araujoms

araujoms commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

I see, yes, that's a more robust solution. At least my PR was useful as a bug report ;)

@kellertuer

Copy link
Copy Markdown
Member

Sometimes old links get outdated - and with that more stable way, we really just missed to update the links. So your PR was the perfect reminder to check and update :)

kellertuer referenced this pull request Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants