change title of embedding objective tutorial#615
Conversation
|
A challenge in that title is, that it really only works if the manifold is embedded in some Euclidean space. But I can think about a better title. |
|
...and yes I mainly wrote that tutorial after I had (a) implemented both the gradient and Hessian conversion (and before that understood them from Nicolas Boumals book) – and explained it 2-3times somewhere on Slack, because this came up a few times. So yeah the title can surely be improved. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #615 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 91 91
Lines 10054 10054
=========================================
Hits 10054 10054 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-authored-by: Ronny Bergmann <git@ronnybergmann.net>
|
Ah now only the Changelog is erroring. It would be great if you could add an entry to the Changelog for a next unreleased version (same as you did for Manopt on your last PR – and again referring to this PR in brackets for completeness :) ) |
|
Perfect, thanks! I might “steal” the 5.40 from you again and merge it into the other PR on the 0.6 then in then end, because that is what we are currently trying to finish :) |
I think the current title can only be understood by people who know enough about the subject that do not need the tutorial. I was specifically looking for this information, and couldn't find the tutorial, just searched for it in the wild. Only after @kellertuer linked it to me that I found it.