Introduce a robust Levenberg-Marquardt#617
Merged
Merged
Conversation
…jl into kt-mb/modified-LM
In this form all seems to be working fine. Very nice! Though I would have expected both variants to produce the same number of iterations.
and run formatter.
…ponentwise (wrapped)
This reverts commit 2f8d323.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev-0.6 #617 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 91 96 +5
Lines 10054 12574 +2520
===========================================
+ Hits 10054 12574 +2520 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mateuszbaran
left a comment
mateuszbaran
left a comment
Member
There was a problem hiding this comment.
A few small-ish comments 🙂
Co-authored-by: Mateusz Baran <mateuszbaran89@gmail.com>
…jl into kt-mb/modified-LM # Conflicts: # Changelog.md # docs/src/notation.md
…d make :Strict the default. ...and fix one typo.
mateuszbaran
approved these changes
Jun 24, 2026
mateuszbaran
left a comment
mateuszbaran
left a comment
Member
There was a problem hiding this comment.
I think this is good enough now 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following https://arxiv.org/abs/2606.23560, this PR introduces a robust Levenberg-Marquardt algorithm for Riemannian manifolds. (see also #332). This should be the last PR to be added to #605.