[AutoBuild] Make julia_compat a required keyword argument#1337
Open
giordano wants to merge 2 commits into
Open
[AutoBuild] Make julia_compat a required keyword argument#1337giordano wants to merge 2 commits into
julia_compat a required keyword argument#1337giordano wants to merge 2 commits into
Conversation
imciner2
reviewed
Jul 10, 2024
| error(""" | ||
| `julia_compat` must be set explicitly to a valid compat spec string. | ||
| If this is an existing recipe which didn't previously specify `julia_compat`, use the old default value of `"1.0"`, | ||
| otherwise for a new recipe you're encouraged to set `julia_compat="1.6"`. |
Member
There was a problem hiding this comment.
Should we make this more generic (e.g. say to the current LTS release)? That way we don't need to update the error messages for newer versions.
Member
Author
There was a problem hiding this comment.
I think sticking to v1.6 is ok, we don't have any particular reason to restrict to newer versions. Maybe I could rephrase slightly to say something along the lines of "at least 1.6"
Member
|
LTS may be too aggressive - and perhaps LTS-1 (1.6) is a good default. |
Member
|
Get this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completely untested, will probably need to adapt some tests, but opening the PR to save my quick progress. Ref: JuliaPackaging/Yggdrasil#9046 (comment). CC: @vchuravy