Implement per-platform compiler version selection#1360
Open
imciner2 wants to merge 8 commits into
Open
Conversation
giordano
reviewed
Jan 3, 2025
imciner2
commented
Jan 3, 2025
imciner2
commented
Jan 3, 2025
imciner2
commented
Jan 3, 2025
imciner2
commented
Jan 3, 2025
imciner2
commented
Jan 3, 2025
imciner2
commented
Jan 3, 2025
imciner2
commented
Jan 4, 2025
Member
|
I wonder if it would be simpler, both in terms of implementation and user interface, to do something like, for example: # In the Yggdrasil `build_tarballs.jl` script:
build_tarballs(ARGS, name, version, sources, script, platforms, products, dependencies;
preferred_gcc_version=(p -> Sys.islinux(p) && arch(p) == "riscv64" ? v"14" : nothing))When |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the ability to select a different compiler version for each requested platform. This can be useful when certain platforms might need a newer version of GCC to fix bugs in the toolchain (e.g., riscv), but we don't want to increase the version for working platforms.
An example use of this is:
This will then use GCC 13 on the RISCV platforms, and GCC 6 on all other platforms.