Skip to content

remove dead code (detect_libstdcxx_version and check_libstdcxx_version) ?#1394

Open
t-bltg wants to merge 2 commits into
JuliaPackaging:masterfrom
t-bltg:rm-dead-code
Open

remove dead code (detect_libstdcxx_version and check_libstdcxx_version) ?#1394
t-bltg wants to merge 2 commits into
JuliaPackaging:masterfrom
t-bltg:rm-dead-code

Conversation

@t-bltg

@t-bltg t-bltg commented Jul 12, 2025

Copy link
Copy Markdown
Contributor

It looks like BinaryBuilder.Auditor.detect_libstdcxx_version and BinaryBuilder.Auditor.check_libstdcxx_version is dead code and not used anywhere in BinaryBuilder, also without any traces of usage anywhere else in the julia ecosystem:
https://github.com/JuliaPackaging/BinaryBuilder.jl/blob/master/src/auditor/compiler_abi.jl#L107-L165

So should they be removed ?

Hoisted out of #1392.

@giordano

Copy link
Copy Markdown
Member

I never touched this code because I always assumed this was meant to be used at some point, since Julia itself also has mechanisms to detect the libstdc++ version (on Linux do Base.BinaryPlatform.HostPlatform()).

@t-bltg

t-bltg commented Jul 16, 2025

Copy link
Copy Markdown
Contributor Author

Ok, I wanted to add tests covering these lines, but they were failing, so I'm not sure what to do here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants