Avoid intermediate string creation in fallback when printing distribution names#2051
Avoid intermediate string creation in fallback when printing distribution names#2051
string creation in fallback when printing distribution names#2051Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2051 +/- ##
=======================================
Coverage 86.46% 86.46%
=======================================
Files 147 147
Lines 8837 8837
=======================================
Hits 7641 7641
Misses 1196 1196 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This change is breaking and removes the function that is quite useful, why not keep the original function for backward compatibility? The new implementation can simply create |
|
This is an internal function, so the change is not breaking. |
|
This is a useful function that can be made public and documented, why not? |
|
Why should it be made public? There's already |
See #2050 (comment)