Skip to content

Avoid intermediate string creation in fallback when printing distribution names#2051

Open
devmotion wants to merge 1 commit intomasterfrom
dmw/print_distrname
Open

Avoid intermediate string creation in fallback when printing distribution names#2051
devmotion wants to merge 1 commit intomasterfrom
dmw/print_distrname

Conversation

@devmotion
Copy link
Copy Markdown
Member

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 61.11111% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.46%. Comparing base (196d79b) to head (2111c8d).

Files with missing lines Patch % Lines
src/multivariate/mvnormalcanon.jl 0.00% 6 Missing ⚠️
src/multivariate/mvnormal.jl 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2051   +/-   ##
=======================================
  Coverage   86.46%   86.46%           
=======================================
  Files         147      147           
  Lines        8837     8837           
=======================================
  Hits         7641     7641           
  Misses       1196     1196           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bvdmitri
Copy link
Copy Markdown
Contributor

bvdmitri commented Apr 3, 2026

This change is breaking and removes the function that is quite useful, why not keep the original function for backward compatibility? The new implementation can simply create IOBuffer, write to it, and return a string from there.

@devmotion
Copy link
Copy Markdown
Member Author

This is an internal function, so the change is not breaking.

@bvdmitri
Copy link
Copy Markdown
Contributor

bvdmitri commented Apr 3, 2026

This is a useful function that can be made public and documented, why not?

@devmotion
Copy link
Copy Markdown
Member Author

Why should it be made public? There's already string, repo, nameof etc., IMO there's no motivation for this function apart from being used in a few internal implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants