Move code depending on CausalInference.jl into extension#523
Open
Move code depending on CausalInference.jl into extension#523
Conversation
Member
Author
|
Extension not yet tested since I can't precompile CI.jl |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #523 +/- ##
==========================================
- Coverage 91.08% 90.29% -0.79%
==========================================
Files 92 93 +1
Lines 2265 2267 +2
==========================================
- Hits 2063 2047 -16
- Misses 202 220 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Hello, Patrick. Yes, I checked here. Lets wait for Moritz answer, maybe we can fix this and open a PR also in CausalInference.jl . Thank you for noticing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves all code depending on CausalInference.jl into an extension to avoid the strong dependency (closes #465). I've noticed that the package is no longer precompiling due to an issue with CausalInference.jl (full stack trace below).
@mschauer @JorgeLuizFranco