Add SSH key authentication with keypath#32
Open
DeniedPyro wants to merge 5 commits intoJuliaWeb:masterfrom
Open
Add SSH key authentication with keypath#32DeniedPyro wants to merge 5 commits intoJuliaWeb:masterfrom
DeniedPyro wants to merge 5 commits intoJuliaWeb:masterfrom
Conversation
Author
|
I can't really run automatic tests on this, since I also can't assign a reviewer on this, @JamesWrigley if you have time to look through it, it would be really appreciated:) |
Member
|
Hmm looks like there are some other issues in CI. Probably unrelated to your change though. I'll have a go at fixing CI in the next couple of weeks (but feel free to bump this if I forget 😛). |
Member
|
Quick update, #33 is close to being ready so I'll try to finish that first, and then rebasing this PR should get CI in the green again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw that the library lacked a high level wrapper for key authentication, I've only added one that uses the filepath of the key!
Feel free to add changes/suggestions!
Use case: