added the skill - #239
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b0fe677b16
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| name: hol-guard-agent-runtime-safety | ||
| description: Agent-runtime safety skill to install and invoke HOL Guard before starting tool-using scientific workflows. |
There was a problem hiding this comment.
Remove the out-of-scope runtime-safety skill
This applies to every local coding-agent harness and only narrows its trigger by saying “scientific workflows”; it is not a skill for a particular scientific package, database, platform, or research workflow. Adding it makes general runtime infrastructure selectable alongside all specialist skills, which the repository explicitly declines because it competes across tasks.
AGENTS.md reference: AGENTS.md:L17-L19
Useful? React with 👍 / 👎.
| --- | ||
| name: hol-guard-agent-runtime-safety | ||
| description: Agent-runtime safety skill to install and invoke HOL Guard before starting tool-using scientific workflows. | ||
| metadata: | ||
| version: "1.0" |
There was a problem hiding this comment.
Declare the required pipx and network environment
The frontmatter provides no compatibility requirements even though the prescribed first step requires both pipx and access to install a package from a package index. In offline or pipx-less environments, agents have no discovery-time indication that this skill cannot run and will select it only to fail at its first command; declare those system and network requirements.
AGENTS.md reference: AGENTS.md:L186-L186
Useful? React with 👍 / 👎.
|
I have investigated the issue. Both feedback comments apply to the hol-guard-agent-runtime-safety I have resolved both requests by completely removing the hol-guard-agent-runtime-safety skill |
Summary
Type of change
Skills touched
How this was tested
Related issues and references
Checklist
Drawn from the Pull Request Checklist in CONTRIBUTING.md. Items that do not apply to this PR can be left unchecked with a short note.
Skill format
namefrontmatter match exactly.SKILL.md,references/,scripts/, andassets/— notests/directory and notest_*.pyfiles.SKILL.mdhas valid YAML frontmatter and a Markdown body.metadata.metadatais a block mapping, not single-line JSON, and scalar values are quoted where needed.metadata.openclawormetadata.hermesblock is a nested mapping, not a JSON string.metadata.versionexists, is quoted, and is bumped if an existing skill changed.descriptionsays both what the skill does and when an agent should use it.Validation and tests
uv run skills-ref validate ./skills/<name>passes.tests/<skill-name>/, and any newscripts/skill has a[skills.<name>]entry intests/skill-requirements.toml.Content and safety
compatibilityand declared inmetadata.openclaw.envVars.Notes for reviewers