Skip to content

fix(security): remove TODO placeholder from SECURITY.md - #249

Open
aniruddhaadak80 wants to merge 1 commit into
K-Dense-AI:mainfrom
aniruddhaadak80:fix/security-md-todo
Open

fix(security): remove TODO placeholder from SECURITY.md#249
aniruddhaadak80 wants to merge 1 commit into
K-Dense-AI:mainfrom
aniruddhaadak80:fix/security-md-todo

Conversation

@aniruddhaadak80

@aniruddhaadak80 aniruddhaadak80 commented Aug 31, 2026

Copy link
Copy Markdown

Summary

Remove lingering maintainer TODO placeholder from the repository's GitHub-surfaced security policy. The HTML comment suggested adding a monitored security@ address or deleting it if private vulnerability reporting is the sole channel — the latter is current practice.

Type of change

  • New skill
  • Update to an existing skill
  • Tests
  • Repository tooling or CI
  • Documentation
  • Other:

Skills touched

none

How this was tested

git diff --stat  # 1 file changed, 3 deletions
cat SECURITY.md  # private reporting via Security tab → Report a vulnerability remains, no TODO
grep -r TODO SECURITY.md  # no results
  • Verified file renders correctly on GitHub and private reporting instructions intact
  • No skill validation needed (skills/ untouched); uv run --with pytest python -m pytest tests/_meta -q unaffected (policy docs not covered by skill contract)

Related issues and references

  • Closes the SECURITY.md TODO flagged by grep -r TODO audit (reported in recon)
  • The TODO comment itself references deletion when private reporting is the only intended route — see SECURITY.md:17 before this change

Checklist

Skill format

  • The skill directory name and the name frontmatter match exactly. (N/A — no skill touched)
  • The skill directory contains only SKILL.md, references/, scripts/, and assets/ — no tests/ directory and no test_*.py files. (N/A)
  • SKILL.md has valid YAML frontmatter and a Markdown body. (N/A)
  • Only the six spec-defined top-level fields are present; everything else lives under metadata. (N/A)
  • metadata is a block mapping, not single-line JSON, and scalar values are quoted where needed. (N/A)
  • Any metadata.openclaw or metadata.hermes block is a nested mapping, not a JSON string. (N/A)
  • metadata.version exists, is quoted, and is bumped if an existing skill changed. (N/A)
  • The description says both what the skill does and when an agent should use it. (N/A)

Validation and tests

  • uv run skills-ref validate ./skills/<name> passes. (N/A — no skill changed)
  • Tests live in tests/<skill-name>/, and any new scripts/ skill has a [skills.<name>] entry in tests/skill-requirements.toml. (N/A)
  • Relevant test suites pass, or the failures are explained below. (tests/_meta unaffected)
  • Security scanner results are clean or explained in this PR. (No code change, no new scan findings)

Content and safety

  • Examples and scripts were tested, or are clearly marked as illustrative. (No examples)
  • No secrets, credentials, private data, or unsafe instructions are included.
  • Credentials the skill needs are named in compatibility and declared in metadata.openclaw.envVars. (N/A)
  • Relevant official documentation is linked where useful. (GitHub private vulnerability reporting)

Notes for reviewers

  • This is a docs-only change; no plugin.json/pyproject.toml version bump needed (collection version unchanged)
  • Low risk; removes 3 lines, preserves authoritative private reporting channel

The HTML comment TODO on line 17 signals immature governance
and is rendered as a pending task to enterprise users. The
comment itself offers the fix: delete it if private vulnerability
reporting via GitHub Security tab is the sole intended channel,
which matches current documented practice.

Removes the TODO comment while preserving the private reporting
instructions as the authoritative channel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant