Skip to content

Sentence Transformer#24

Closed
nadiaverdha wants to merge 20 commits into
KRLabsOrg:mainfrom
nadiaverdha:main
Closed

Sentence Transformer#24
nadiaverdha wants to merge 20 commits into
KRLabsOrg:mainfrom
nadiaverdha:main

Conversation

@nadiaverdha

Copy link
Copy Markdown
Collaborator

Hi Adam,

this would be the work for the sentence transformer model. I tested the functionalities and as far as I checked all is working . I still need to train the final model but I thought I woud anyway open a PR.

Thanks a lot for your help with the code. Hope everything is fine!

Thank you!

Best,
Nadia

@nadiaverdha nadiaverdha closed this Jun 3, 2025
@nadiaverdha nadiaverdha reopened this Jun 3, 2025
@adaamko

adaamko commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Hi Nadia — thank you so much for this, and for the careful testing. Since you opened it the project moved to the v2 line (generative typed-span detector + the mmBERT encoder and taxonomy cascade), and the architecture has shifted enough that the Sentence-Transformer path no longer lines up with the current codebase. I'm going to close this PR for now, but I really appreciate the work — and if you'd like to pick up one of the new help wanted issues (e.g. the Lfm2Bi encoder or the span-based safety work), I'd be glad to support it. Thanks again!

@adaamko adaamko closed this Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants