Sentence Transformer#24
Closed
nadiaverdha wants to merge 20 commits into
Closed
Conversation
Collaborator
|
Hi Nadia — thank you so much for this, and for the careful testing. Since you opened it the project moved to the v2 line (generative typed-span detector + the mmBERT encoder and taxonomy cascade), and the architecture has shifted enough that the Sentence-Transformer path no longer lines up with the current codebase. I'm going to close this PR for now, but I really appreciate the work — and if you'd like to pick up one of the new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Adam,
this would be the work for the sentence transformer model. I tested the functionalities and as far as I checked all is working . I still need to train the final model but I thought I woud anyway open a PR.
Thanks a lot for your help with the code. Hope everything is fine!
Thank you!
Best,
Nadia