The saving of self-calibration data to the EEPROM has been disabled, …#473
Open
javisnbz wants to merge 1 commit into
Open
The saving of self-calibration data to the EEPROM has been disabled, …#473javisnbz wants to merge 1 commit into
javisnbz wants to merge 1 commit into
Conversation
…preventing it from replacing manual calibration data. The saving of self-calibration data to the EEPROM has been disabled, preventing it from replacing manual calibration data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The auto-calibration function ends up persistently writing data to the EEPROM, overwriting the data from the manual calibration done in Keychron Launcher. When manually calibrating in Keychron Launcher, the keys show a perfect travel between 0mm and 4mm, allowing customization of the actuation point to the desired millimeters (one of the advantages of using an HE keyboard). The problem is that with use, the auto-calibration replaces the manual calibration values, causing some keys to have a maximum travel of 1.8mm, others 3.0mm, etc., affecting typing and making it dependent on the auto-calibration in temporary RAM to "correct" this discrepancy.
I modified the firmware, preventing the
auto_calibration_checkfunction, which callssave_calibration_value, from persistently writing data. I'm using the modified firmware, and the keyboard doesn't show any problems since the manual calibration isn't affected. All the keys respond between 0mm and 4mm when turned on, and I can use any actuation point I want.Types of Changes
Issues Fixed or Closed by This PR
Checklist