Revert "Completed prototype development"#2
Merged
Conversation
This reverts commit 7388276.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts a previous prototype development (#1), effectively removing the completed implementation and returning the codebase to a placeholder state with stub methods.
Changes:
- Removed all functional implementation code from the CA plugin
- Reverted configuration files and integration manifests
- Removed documentation and workflow files
- Replaced implemented methods with
NotImplementedExceptionplaceholders
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| nexus-certificate-manager-caplugin/models/Helpers.cs | Deleted entire helper class with certificate parsing, status mapping, and REST response handling utilities |
| nexus-certificate-manager-caplugin/models/ApiModels.cs | Removed API model classes, query parameter builders, and response handling helpers |
| nexus-certificate-manager-caplugin/manifest.json | Reverted plugin references from NexusCertManager back to DigiCert |
| nexus-certificate-manager-caplugin/NexusCertManagerClient.cs | Removed REST client implementation, replaced with stub methods |
| nexus-certificate-manager-caplugin/NexusCertManagerCAPluginConfig.cs | Removed configuration properties |
| nexus-certificate-manager-caplugin/NexusCertManagerCAPlugin.csproj | Removed package dependencies and build configurations |
| nexus-certificate-manager-caplugin/NexusCertManagerCAPlugin.cs | Removed plugin implementation, replaced with stub methods throwing NotImplementedException |
| nexus-certificate-manager-caplugin/Constants.cs | Deleted constants file |
| integration-manifest.json | Deleted integration manifest |
| docsource/configuration.md | Deleted configuration documentation |
| NexusCertManagerCAPlugin.sln | Updated solution items references |
| CHANGELOG.md | Deleted changelog |
| .github/workflows/keyfactor-bootstrap-workflow.yml | Deleted GitHub workflow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+5
to
+6
| "assemblypath": "DigicertCAPlugin.dll", | ||
| "TypeFullName": "Keyfactor.Extensions.CAPlugin.DigiCert.CertCentralCAPlugin" |
There was a problem hiding this comment.
The manifest references DigiCert plugin assembly and types that don't exist in this codebase. These should reference the NexusCertManager plugin: assembly should be 'NexusCertManagerCAPlugin.dll' and TypeFullName should be 'Keyfactor.Extensions.CAPlugin.NexusCertManager.NexusCertManagerCAPlugin'.
Suggested change
| "assemblypath": "DigicertCAPlugin.dll", | |
| "TypeFullName": "Keyfactor.Extensions.CAPlugin.DigiCert.CertCentralCAPlugin" | |
| "assemblypath": "NexusCertManagerCAPlugin.dll", | |
| "TypeFullName": "Keyfactor.Extensions.CAPlugin.NexusCertManager.NexusCertManagerCAPlugin" |
Comment on lines
+190
to
+192
|
|
||
| [JsonPropertyName("signature")] | ||
| public string Signature { get; set; } |
There was a problem hiding this comment.
The Signature property is being added to RevokeCertificateRequest, but this appears to be part of a revert. If this property was not in the original code before the prototype, it should also be removed to fully revert the changes.
Suggested change
| [JsonPropertyName("signature")] | |
| public string Signature { get; set; } |
indrora
added a commit
that referenced
this pull request
Jan 29, 2026
* feat: release 1.1.1 * Implemented enrollment, added helper methods and API response handlers * implemented cert retrieval methods on client. * added additional logging, implemented revoke on client * implemented sync and revoke; completed initial functionality * added changelog and license headers * added manifest, disabled auth cert domain check for nexus auth cert * Updated enrollment to include first available procname for enrollment (error when there is no default set). * updated request format for revocation * cleanup * documentation updates * updated project settings for github build * added keyfactor-bootstrap-workflow.yml * updated manifest * added docsource folder * corrected the returned value on a revoke request * Update nexus-certificate-manager-caplugin/NexusCertManagerCAPlugin.cs flattening exception to retain potential useful info Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update docsource/configuration.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update nexus-certificate-manager-caplugin/NexusCertManagerClient.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update nexus-certificate-manager-caplugin/models/Helpers.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update nexus-certificate-manager-caplugin/NexusCertManagerCAPlugin.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update nexus-certificate-manager-caplugin/NexusCertManagerClient.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update nexus-certificate-manager-caplugin/NexusCertManagerCAPlugin.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update nexus-certificate-manager-caplugin/NexusCertManagerClient.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update nexus-certificate-manager-caplugin/NexusCertManagerCAPlugin.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * added check for partial sync * Update nexus-certificate-manager-caplugin/NexusCertManagerCAPlugin.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * updating manifest for doctool build --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Revert "feat: release 1.1.1" (#2) This reverts commit 7388276. --------- Co-authored-by: Joe VanWanzeele <76071503+joevanwanzeeleKF@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
indrora
added a commit
that referenced
this pull request
Mar 9, 2026
* Merge 1.0.0 to main (#3) * feat: release 1.1.1 * Implemented enrollment, added helper methods and API response handlers * implemented cert retrieval methods on client. * added additional logging, implemented revoke on client * implemented sync and revoke; completed initial functionality * added changelog and license headers * added manifest, disabled auth cert domain check for nexus auth cert * Updated enrollment to include first available procname for enrollment (error when there is no default set). * updated request format for revocation * cleanup * documentation updates * updated project settings for github build * added keyfactor-bootstrap-workflow.yml * updated manifest * added docsource folder * corrected the returned value on a revoke request * Update nexus-certificate-manager-caplugin/NexusCertManagerCAPlugin.cs flattening exception to retain potential useful info Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update docsource/configuration.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update nexus-certificate-manager-caplugin/NexusCertManagerClient.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update nexus-certificate-manager-caplugin/models/Helpers.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update nexus-certificate-manager-caplugin/NexusCertManagerCAPlugin.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update nexus-certificate-manager-caplugin/NexusCertManagerClient.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update nexus-certificate-manager-caplugin/NexusCertManagerCAPlugin.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update nexus-certificate-manager-caplugin/NexusCertManagerClient.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update nexus-certificate-manager-caplugin/NexusCertManagerCAPlugin.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * added check for partial sync * Update nexus-certificate-manager-caplugin/NexusCertManagerCAPlugin.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * updating manifest for doctool build --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Revert "feat: release 1.1.1" (#2) This reverts commit 7388276. --------- Co-authored-by: Joe VanWanzeele <76071503+joevanwanzeeleKF@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update keyfactor-bootstrap-workflow.yml * Update keyfactor-bootstrap-workflow.yml * chore(ci): add missing inputs to v4 actions * Update generated docs * chore(docs): Minor doc fixes. * Update generated docs --------- Co-authored-by: Morgan Gangwere <470584+indrora@users.noreply.github.com> Co-authored-by: Joe VanWanzeele <76071503+joevanwanzeeleKF@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Morgan Gangwere <morgan.gangwere@keyfactor.com> Co-authored-by: Keyfactor <keyfactor@keyfactor.github.io>
indrora
added a commit
that referenced
this pull request
Mar 9, 2026
* Merge 1.0.0 to main (#3) * feat: release 1.1.1 * Implemented enrollment, added helper methods and API response handlers * implemented cert retrieval methods on client. * added additional logging, implemented revoke on client * implemented sync and revoke; completed initial functionality * added changelog and license headers * added manifest, disabled auth cert domain check for nexus auth cert * Updated enrollment to include first available procname for enrollment (error when there is no default set). * updated request format for revocation * cleanup * documentation updates * updated project settings for github build * added keyfactor-bootstrap-workflow.yml * updated manifest * added docsource folder * corrected the returned value on a revoke request * Update nexus-certificate-manager-caplugin/NexusCertManagerCAPlugin.cs flattening exception to retain potential useful info * Update docsource/configuration.md * Update nexus-certificate-manager-caplugin/NexusCertManagerClient.cs * Update nexus-certificate-manager-caplugin/models/Helpers.cs * Update nexus-certificate-manager-caplugin/NexusCertManagerCAPlugin.cs * Update nexus-certificate-manager-caplugin/NexusCertManagerClient.cs * Update nexus-certificate-manager-caplugin/NexusCertManagerCAPlugin.cs * Update nexus-certificate-manager-caplugin/NexusCertManagerClient.cs * Update nexus-certificate-manager-caplugin/NexusCertManagerCAPlugin.cs * added check for partial sync * Update nexus-certificate-manager-caplugin/NexusCertManagerCAPlugin.cs * updating manifest for doctool build --------- * Revert "feat: release 1.1.1" (#2) This reverts commit 7388276. --------- * Update keyfactor-bootstrap-workflow.yml * Update keyfactor-bootstrap-workflow.yml * chore(ci): add missing inputs to v4 actions * Update generated docs * chore(docs): Minor doc fixes. * Update generated docs --------- Co-authored-by: Sean <1661003+spbsoluble@users.noreply.github.com> Co-authored-by: Joe VanWanzeele <76071503+joevanwanzeeleKF@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Keyfactor <keyfactor@keyfactor.github.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1