Skip to content

Update third-party actions to versions that use Node v24#100

Merged
kevinb-khan merged 3 commits intomainfrom
fei-7601
Mar 31, 2026
Merged

Update third-party actions to versions that use Node v24#100
kevinb-khan merged 3 commits intomainfrom
fei-7601

Conversation

@kevinb-khan
Copy link
Copy Markdown
Contributor

@kevinb-khan kevinb-khan commented Mar 30, 2026

Summary:

In addition to update all workflows to use Node v24, we also need to update all third-party actions to versions that use Node v24.

Issue: FEI-7601

Test plan:

  • let CI run and look at the warnings

NOTE:

  • gerald-pr.yml uses Khan/actions' action/gerald-pr/action.yml which in turn uses Khan/gerald so I will need to update this repo and that repo again before this warning can be fixed
Screenshot 2026-03-30 at 5 50 27 PM

@kevinb-khan kevinb-khan self-assigned this Mar 30, 2026
@khan-actions-bot khan-actions-bot requested review from a team, jaredly and jeresig and removed request for a team March 30, 2026 21:33
@khan-actions-bot
Copy link
Copy Markdown
Contributor

khan-actions-bot commented Mar 30, 2026

Gerald

Required Reviewers
  • @Khan/github-actions for changes to .github/workflows/build.yml, .github/workflows/gerald-comment.yml, .github/workflows/gerald-pr.yml, .github/workflows/gerald-push.yml, .github/workflows/pr-actions.yml, .github/workflows/pr-autofix.yml, .github/actions/setup/action.yml

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@khan-actions-bot khan-actions-bot requested a review from a team March 30, 2026 21:35
@kevinb-khan kevinb-khan merged commit 12060c8 into main Mar 31, 2026
6 checks passed
@kevinb-khan kevinb-khan deleted the fei-7601 branch March 31, 2026 15:41
kevinb-khan added a commit to Khan/actions that referenced this pull request Mar 31, 2026
…v24 everywhere (#157)

## Summary:
In Khan/gerald#100, I update the third-party actions that Khan/gerald's uses to versions that use Node v24 (instead of v20).  This PR updates the actions wrapper in this repo to use the new version of that action.

Issue: FEI-7601

## Test plan:
- see that there are no warnings about Node v20 actions in CI

I retried Gerald a few times because it looked like it wasn't running, that's why there are three reports.  One the plus side, none of them show warnings about Node v20.  Here's a link to one of the runs to show that it actually did run: https://github.com/Khan/actions/actions/runs/23815675785/job/69414414986.

<img width="622" height="392" alt="Screenshot 2026-03-31 at 3 36 02 PM" src="https://github.com/user-attachments/assets/f96afe88-34af-4858-be53-365b9860215f" />

Author: kevinb-khan

Reviewers: jeresig, jaredly

Required Reviewers:

Approved By: jeresig

Checks: ⏭️  1 check has been skipped, ✅ 2 checks were successful

Pull Request URL: #157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants