spirv-val: Fix newline not marked as a line for DebugShaderInfo#6623
Conversation
@Keenuts can you help me get the final SPIR-V for this as well... curious if this is also yet-another edge case not hitting (the other CI issues are around spirv-opt generated output I'm gonna look into) |
Line 22 col 15 in the source HLSL seems to point correctly to |
|
@Keenuts ok, so this one seems like a dxc error, the where and so If we are going to count |
|
Hi, Sorry missed your replies. But the line 22 of the shader is: So seems like the line count is wrong somewhere, because SPIR-V and HLSL shows the debug info are correct. Looking at the SPIR-V, I have: And those strings are defined by: This gives me the following shader: On your reply, you are putting %23 and %21 on 2 different lines, but those are not: there is no newline in the string. |
So this might be the problem, I see not thing around how you can split up a single line across two ... it makes sense as it uses |
79d74da to
97cbda9
Compare
|
... lets see if this works, think I got it now |
|
@Keenuts I can't see why is this still failing? I don't see any error, just a failed test |
|
shader.debug.sourcecontinued.hlsl is an unexpected pass now. |
follow up of the issues @Keenuts was finding in #5986
summary is the following
was not counting
line 3as a zero-length, empty line and it would cause an off-by-1 later below it(should fix the failing DXC CI as well)