Skip to content

Add job filter for recipes#360

Merged
KonaeAkira merged 12 commits into
KonaeAkira:previewfrom
jmerdich:job-filter
Jun 16, 2026
Merged

Add job filter for recipes#360
KonaeAkira merged 12 commits into
KonaeAkira:previewfrom
jmerdich:job-filter

Conversation

@jmerdich

@jmerdich jmerdich commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

This adds a new "Active Job Only" checkbox to the recipe pane which limits the shown recipes/missions to the currently selected job. Equivalent options are also added to the command line, the queries have been converted from nameless tuples to structs, and new tests are added.

Closes #343

This adds a new "Active Job Only" checkbox to the recipe pane which limits the shown recipes/missions to the currently selected job.  Equivalent options are also added to the command line, the queries have been converted from nameless tuples to structs, and new tests are added.

Implements KonaeAkira#343

@augenfrosch augenfrosch left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
I was actually planning on working on this before getting sidetracked by my UI code refactor PR, so I have some thoughts on your implementation.

I'm marking this review with "Request changes", since the UI changes have some problems when the available width is limited, e.g., on smartphones, see my comment on recipe_select.rs. The other comments are more nitpicky and are not that important.

Comment thread raphael-data/src/search.rs Outdated
Comment thread raphael-cli/src/commands/search_mission.rs Outdated
Comment thread raphael-cli/src/commands/search_mission.rs Outdated
Comment thread raphael-cli/src/commands/search_recipe.rs Outdated
Comment thread raphael-data/src/locales.rs Outdated
Comment thread src/elements/panels/recipe_select.rs Outdated
Comment thread src/elements/panels/recipe_select.rs Outdated
Comment thread src/elements/panels/recipe_select.rs Outdated
Comment thread raphael-data/tests/test_recipes.rs Outdated
Comment thread raphael-data/tests/test_stellar_missions.rs Outdated
@augenfrosch augenfrosch added enhancement A-gui Area: Graphical user interface A-cli Area: Command-line interface labels Jun 16, 2026

@augenfrosch augenfrosch left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More general comments this time (including something I missed in my first review, sorry about that).

Looking at the current UI, there are still some things that could be improved:

  • There probably should be some visual indication that a filter is currently being used, similar to how buffed stats are highlighted
  • The cog "⚙" looks a bit out-of-place to me, something like a funnel would be more appropriate. But looking at the egui default fonts, there doesn't seem to be a glyph for that (but there also isn't a funnel emoji, so that is not really unexpected). Maybe basic shapes could be used to draw a custom funnel icon, what egui does for the collapsing header icons came to mind.

But besides the failing CI / Clippy lint (that you already fixed in the time it took me to get around to finishing this review), I think this could be merged as is. I can work on the things mentioned in my comments in a follow-up PR if you prefer, or you could make the changes yourself.

Comment thread src/elements/panels/recipe_select.rs Outdated
Comment thread src/elements/panels/recipe_select.rs Outdated
Comment thread src/elements/panels/recipe_select.rs Outdated
Comment thread src/elements/panels/recipe_select.rs Outdated
@jmerdich

Copy link
Copy Markdown
Contributor Author

If you can work on the two items you listed here in a follow-up, that'd be great. I'm pretty happy with just the cog on the right.

@KonaeAkira KonaeAkira left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @jmerdich for the PR and thank you @augenfrosch for reviewing ^^

@KonaeAkira KonaeAkira merged commit 27c5c81 into KonaeAkira:preview Jun 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area: Command-line interface A-gui Area: Graphical user interface enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Filter stellar missions on job.

3 participants