feat: add --no-expand-env-vars flag to deck file convert#1977
Merged
Conversation
a884c35 to
c119f86
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1977 +/- ##
==========================================
- Coverage 32.58% 32.52% -0.06%
==========================================
Files 77 77
Lines 6903 6914 +11
==========================================
Hits 2249 2249
- Misses 4474 4485 +11
Partials 180 180 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
This implementation isn't correct. Instead, let's wait for Kong/go-database-reconciler#444 then use the new mode in this PR |
Contributor
🤔 But that PR uses this deck branches' commit ID in go.mod |
0457350 to
914d21a
Compare
914d21a to
2d147bf
Compare
2d147bf to
ead162b
Compare
Member
Author
|
Implementation updated to use the GDR methods |
ead162b to
456bff3
Compare
harshadixit12
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
deck file convertalways expanded env placeholders (e.g.${{ env "DECK_VAR_NAME" }}) in its output, with no way to suppress this. Users who want to convert format while keeping env references intact — for example, to commit the converted file and resolve secrets at deploy time — had no option to do so.What changed
Added a
--no-expand-env-varsboolean flag (defaultfalse) todeck file convert. When set, env placeholders are left unexpanded, matching the mock-env-vars behaviour already available indeck file render.The flag is wired through both convert code paths: single-file conversion and the 2.x→3.x batch conversion.
Usage:
Default behaviour is unchanged — env vars are still expanded unless the flag is passed.