fix: add dockerfile syntax directive for heredocs - #818
Open
Namanlashkari wants to merge 2 commits into
Open
Conversation
The luarocks install step uses RUN <<-EOF. Without # syntax=docker/dockerfile:1, older Docker frontends parse the heredoc body as instructions and fail. Fix Kong#730
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
assets/DockerfileusesRUN <<-EOFfor the LuaRocks install. Docker daemons that still default to thedockerfile.v0frontend parse the heredoc body as instructions and fail:#730
Fix
Add
# syntax=docker/dockerfile:1as the first line so BuildKit pulls the modern frontend regardless of the daemon built-in.Testing
Manual:
assets/Dockerfilestarts with# syntax=docker/dockerfile:1RUN <<-EOFblock is unchangedCI: