Open
Conversation
AyoungSe0
reviewed
Mar 27, 2026
AyoungSe0
left a comment
AyoungSe0
left a comment
There was a problem hiding this comment.
MainActivity에서 Week02() 호출해주시면 실행 화면에서도 구현 내용을 확인하실 수 있습니다! 각 파일 별로 프리뷰로 확인하는 습관 너무 좋은 것 같아요~
뉴스 로고 이미지, 시계 아이콘, 더보기 아이콘 등이 반 되어 있지 않네요! 해당 부분까지 추가되면 더 좋을 것 같습니다~
전반적으로 컴포넌트를 분리해서 구조적으로 너무 잘 해주셨습니다!!
| modifier = Modifier.fillMaxWidth(), | ||
| horizontalArrangement = Arrangement.SpaceBetween | ||
| ) { | ||
| Text( |
There was a problem hiding this comment.
TextStyle(shadow) 추가해주시면 피그마와 디자인을 일치시킬 수 있습니다!
| horizontalArrangement = Arrangement.spacedBy(10.dp) | ||
| ) { | ||
| items(LabelItem.getLabelList()){ item -> | ||
| Text(text = item, fontSize = 16.sp) |
There was a problem hiding this comment.
if 를 사용해서 color 속성을 바꿔주면 피그마 디자인과 일치시킬 수 있습니다!
예) color = if (index == 0) Color.Black else ...
| verticalArrangement = Arrangement.spacedBy(16.dp) | ||
| ) { | ||
| items(NewsItem.getNewsItemList()){item -> | ||
| Row( |
| fontSize = 13.sp, | ||
| color = Color(0xFF4E4B66) | ||
| ) | ||
| Text( |
There was a problem hiding this comment.
긴 텍스트에 대응하기 위해 maxLines/overflow 처리가 필요해 보입니다!
예) maxLines = 2, overflow = TextOverflow.Ellipsis
| @Composable | ||
| fun Week02(modifier: Modifier = Modifier) { | ||
| Box( | ||
| modifier = Modifier.padding(24.dp) |
There was a problem hiding this comment.
상하좌우에 패딩이 들어가서, 하단에는 패딩이 적용 안되도록 수정하는 게 좋을 것 같습니다!
예) .padding(start = 24.dp, top = 24.dp, end = 24.dp)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. 미션
각 주차에 해당하는 미션 체크리스트
2. 구현에 대한 설명
본인이 구현한 것에 대한 설명
3. 스크린샷 & 실행영상
실행영상이 있다면 실행영상을, 없다면 스크린샷 첨부
4. 기타
기타 문의사항이나 질문사항, 그 외 하고싶은 말