Open
Conversation
About kim/week1
AyoungSe0
reviewed
Mar 27, 2026
AyoungSe0
left a comment
AyoungSe0
left a comment
There was a problem hiding this comment.
로고처럼 svg로 다운받을 수 있는 에셋은 svg로 다운받아 사용하면 화질이 깨지지 않아 좋습니다!
전반적으로 피그마와 거의 동일하게 구현되어 있어서, 디자인 꼼꼼히 반영하신 점이 너무 좋았습니다!!
| } | ||
|
|
||
| } | ||
| Greeting( |
There was a problem hiding this comment.
NewsScreen을 호출해주시면 실행 화면에서도 확인하실 수 있습니다!
예) NewsScreen(modifier = Modifier.padding(innerPadding))
| val categories = listOf("All", "Sports", "Politics", "Business", "Health", "Travel", "Science", "Fashion") | ||
|
|
||
| Column( | ||
| modifier = Modifier |
There was a problem hiding this comment.
Scaffold 사용 시 인자로 받은 modifier를 사용해 주는 것이 좋습니다!(상단 상태바와 겹침)
| Spacer(modifier = Modifier.height(4.dp)) | ||
|
|
||
| // 제목 | ||
| Text( |
There was a problem hiding this comment.
긴 텍스트에 대응하기 위해 maxLines/ellipsis 를 처리해주는 것이 좋아 보입니다!
예) maxLines = 2, overflow = TextOverflow.Ellipsis
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. 미션
각 주차에 해당하는 미션 체크리스트
뉴스 화면 구현하기
기사 본문과 카테고리를 더욱 늘려 lazyView 실 사용하기
2. 구현에 대한 설명
본인이 구현한 것에 대한 설명
3. 스크린샷 & 실행영상
실행영상이 있다면 실행영상을, 없다면 스크린샷 첨부
4. 기타
기타 문의사항이나 질문사항, 그 외 하고싶은 말