Open
Conversation
AyoungSe0
reviewed
Apr 4, 2026
AyoungSe0
left a comment
AyoungSe0
left a comment
There was a problem hiding this comment.
이번 주차는 간단한 미션이었던 만큼 전체적으로 구조도 깔끔하게 너무 잘 해주셨네요 ㅎㅎ
지금은 HomeDetail 화면과 ContactDetail 화면에서 어떤 하단 탭에도 속하지 않도록 처리되어 있는데, 추후에는 상세화면에서 하단 네비게이션바를 숨김 처리하는 방식도 적용해보시면 좋을 것 같아요~!
| composable(Route.CONTACT_DETAIL.route) { | ||
| // 이전 화면에서 savedStateHandle에 저장해둔 데이터를 꺼내옵니다. | ||
| val call = navController.previousBackStackEntry | ||
| ?.savedStateHandle |
There was a problem hiding this comment.
안전하게 article == null일 때의 처리도 해주면 좋을 것 같습니다(popBackStack() 등)
AyoungSe0
reviewed
Apr 4, 2026
| call?.let { | ||
| ContactDetailScreen( | ||
| call = it, | ||
| navController = navController |
There was a problem hiding this comment.
상세 화면에 navController 전체를 넘기지 않고 onClick만 넘겨주셔도 좋을 것 같습니다~!
AyoungSe0
reviewed
Apr 4, 2026
| modifier: Modifier = Modifier | ||
| ) { | ||
| val scrollState = rememberScrollState() | ||
| val imageRes = when (article.newspaper) { |
There was a problem hiding this comment.
HomeScreen에서 중복돼서 쓰인 코드라, 함수로 만들어서 써도 좋을 것 같습니다!
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. 미션
각 주차에 해당하는 미션 체크리스트
구현에 대한 설명
3. 스크린샷 & 실행영상