CBOR untaggedNullValueTags configuration option (#2966)#3074
Open
travishaagen wants to merge 2 commits intoKotlin:masterfrom
Open
CBOR untaggedNullValueTags configuration option (#2966)#3074travishaagen wants to merge 2 commits intoKotlin:masterfrom
travishaagen wants to merge 2 commits intoKotlin:masterfrom
Conversation
Author
|
@fzhinkin Hello! Thanks for taking a look. How can I help move this forward? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a new CBOR configuration option called
untaggedNullValueTags. When enabled, CBOR value-tags will not be serialized fornullvalues, and deserialization will not fail validation. This is allowed by the CBOR spec as mentioned in this issue.When
untaggedNullValueTags=true, the encoding for the provided unit test is https://cbor.me/?bytes=bf6161a0d8226162f6d8386163f66164f6ff where the tags shown below are key-tags,For comparison, when
untaggedNullValueTags=false, the encoding is https://cbor.me/?bytes=bf6161cca0d8226162f6d8386163d84ef66164d85accf6ffNote however, that Kotlinx Serialization cannot currently deserialize the above anyhow.
This change is needed for a real world use-case, where "untagged
nullvalues" are a requirement for value-tags. Thank you!