Conversation
shanshin
force-pushed
the
gradle-9
branch
2 times, most recently
from
04b0737 to
1d3689f
Compare
Contributor
Author
|
New limitation: minimal JVM version is 17 |
shanshin
commented
Sep 19, 2025
| }) | ||
| // TODO fix the migration issue | ||
| // source(compileTask.map { | ||
| // @Suppress("INVISIBLE_MEMBER") |
Contributor
Author
There was a problem hiding this comment.
@Tapchicoma, could you please help with fixing this problem?
shanshin
commented
Sep 19, 2025
| it.commonSourceSet | ||
| }) | ||
| // TODO fix the migration issue | ||
| // @Suppress("INVISIBLE_MEMBER") |
shanshin
commented
Sep 19, 2025
| val generator: TaskProvider<Task?> = null | ||
| setModuleDescriptorGenerator(generator) | ||
| // TODO fix the migration issue | ||
| // @Suppress("NULL_FOR_NONNULL_TYPE") |
Member
|
@Tapchicoma PTAL |
Tapchicoma
reviewed
Oct 27, 2025
| @@ -1,11 +1,11 @@ | |||
| [versions] | |||
| kotlin = "2.2.0" | |||
Contributor
There was a problem hiding this comment.
I would suggest first updating this repo to Kotlin 2.2.21, as it contains an important fix for Gradle 9.0.0 support
Contributor
Author
There was a problem hiding this comment.
Ok.
However, the problems with Java modularity are not due to Gradle compatibility - they are due to using the outdated KGP API and I'm not aware how to correct them correctly.
And one problem is that @Suppress("NULL_FOR_NONNULL_TYPE") does not work in K2 - perhaps there are also ready-made solutions here on how to do this in a different way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.