Added Documentation and Unit Tests for HTTP Requests Logging - #78
Merged
Conversation
Burgyn
requested changes
Dec 10, 2025
| [Theory] | ||
| [InlineData(false)] | ||
| [InlineData(true)] | ||
| public async Task LogRequestLogEntry(bool shouldFail) |
Member
There was a problem hiding this comment.
Neviem či to takto spájať do jedného testu.
Lebo napríklad by som očakával, že pri testovaní tej exception aj overíme status kód, ...
…hStatusCode and LogRequestWhenException
Burgyn
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds documentation and unit tests for the last implemented feature of structured HTTP requests logging, along with some other small code fixes.
Documentation updates:
--requests-log-fileoption, describing its usage and example JSON content.Feature implementation:
RequestLogFileEntrymodel to always provideEndTimeandDurationMsas non-null values, since they should never be null.Testing:
RequestsLoggingHandlerShouldto verify that HTTP requests logging works correctly, including cases for successful requests, failures, missing context, and multiple consecutive requests.