Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new KyberSwap DEX adapter implementation for Wasabi Prop AMM pools on Base, along with a mainnet-fork Foundry test to validate swap execution against real deployed contracts.
Changes:
- Introduce
WasabiPropAmmAdapterthat swaps against a WasabiPropPoolusingswapExactInput. - Add
IPropPoolinterface used by the adapter to interact with Wasabi pools. - Add a Base mainnet-fork fuzz test covering both base→USDC and USDC→base swap directions.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/adapters/wasabi-prop-amm/WasabiPropAmmAdapter.sol |
New adapter contract that decodes a PropPool address from calldata, approves tokenIn, and executes an exact-input swap. |
src/adapters/wasabi-prop-amm/IPropPool.sol |
Interface definition for interacting with Wasabi PropPool contracts (swap + base/quote token getters). |
test/adapters/wasabi-prop-amm/WasabiPropAmmAdapter.t.sol |
Base mainnet-fork test that funds the adapter, executes swaps, and asserts output accounting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
thepluck
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
Each Wasabi Prop AMM pool pairs a single base token (e.g. WETH) with USDC as the quote token. The adapter handles one pool per call -- for token-to-token routes (e.g. WETH -> WBTC), the aggregator chains two calls through USDC.
The data parameter encodes only the pool address:
ERC20 output tokens are left in the adapter for the framework to collect. Native token wrapping/unwrapping is handled by KyberSwap's internal flow and does not need to be implemented in the adapter.
Deployment note: The adapter contract must be granted AUTHORIZED_SWAPPER_ROLE (role 100) on the PropPoolFactory's access manager after deployment.