fix(wallet): use metamask:// scheme for mobile connect deep link#3216
Merged
Conversation
…oval screen The mobile deep link was rewritten to the metamask.app.link Universal Link before being handed to the wallet modal. That domain is a Branch link that drops arbitrary query params on the handoff to the app, so MetaMask opened to its home screen without the MWP pairing payload and never showed the connection request. Pass the metamask:// custom scheme through unchanged: it carries the payload straight into the app so MetaMask lands on the approval screen, and tapping a custom-scheme link keeps the dapp page (and its open relay connection) alive. Add an explicit store link for users without the app instead of relying on a timer fallback.
Auto Deploy Pull RequestADPR instance has been created! Information
|
tienkane
changed the title
Auto Deploy Pull RequestClean up resources have been completed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
metamask://connect/mwpdeep link to the wallet modal unchanged instead of rewriting it to themetamask.app.linkUniversal Link. The custom scheme carries the connection payload straight into MetaMask so it opens on the pairing/approval screen; themetamask.app.link(Branch) link drops the query params on the handoff, so the app opened to its home screen with no connection request.