Skip to content

StoreUsageCharge FormRequest has empty $this->request #464

Description

@FikretCin

Expected Behavior

StoreUsageCharge request class (which extends FormRequest) should allow access to request input parameters using standard Laravel request accessor methods.

Inside the request class, input values such as price, description, signature, or any other parameter should be retrievable reliably.

Current Behavior

In Osiset\ShopifyApp\Http\Requests\StoreUsageCharge, the $this->request object is always empty.

Debug output from the attached screenshot clearly shows:

$this->request->all() → []
$this->request->has('redirect') → false
$this->request->get('price') → null
$this->request->get('description') → null
$this->request->get('signature') → null

However, the same values are present in the request and can be accessed correctly when using FormRequest’s own accessors:

$this->all() → ['price' => '1', 'description' => 'Five e-mails', 'signature' => 'hmac-value', ...]
$this->input('price') → "1"
$this->input('description') → "Five e-mails"
$this->input('signature') → "hmac-value"

Root Cause

Since the class extends FormRequest, input access should not rely on $this->request, but instead use:

$this->get()
$this->input()
$this->all()
$this->has()
$this->query()

Failure Information

The bug prevents request parameters from being read when $this->request is used inside the request class, including inside withValidator() where HMAC verification is performed.

Context

  • Package Version: v25.1
  • Laravel Version: v12
  • PHP Version: v8.4

Failure Logs

No exception is thrown, but debugging confirms the request object is not populated:

$this->request → []
$this->all() → contains valid input

Attachment

Image

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingunconfirmedBug has not been reproduced yet

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions