Add corona profile#64
Merged
Merged
Conversation
tbennun
requested changes
Mar 18, 2026
tbennun
left a comment
tbennun
left a comment
Collaborator
There was a problem hiding this comment.
minor comment but otherwise looks good to go!
| return Sierra(sys) | ||
|
|
||
| # Try to find current system via other means | ||
| if sys in ("corona"): |
Collaborator
There was a problem hiding this comment.
Suggested change
| if sys in ("corona"): | |
| if sys == "corona": |
Contributor
Author
There was a problem hiding this comment.
Thanks for taking a look! I just made that update. :)
Contributor
Author
|
Hey Tal, I made the change manually. Let me know if there's anything else I should do, and thanks a lot! |
tbennun
approved these changes
Apr 1, 2026
Collaborator
|
Thank you! LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking at
launchvs.flux runperformance using a small distributed training example and noticed Corona didn't have a system profile. Absent a profile,hpc-launcherfalls back to a generic AMD configuration on Corona, and in my testslaunchruns did not outperformflux run.This PR adds a Corona system profile (drafted with Codex help). With this profile, my example improves from ~11 seconds/epoch with
flux runto ~8 seconds/epoch withlaunch. Thelaunchvsflux rungap is still smaller than what I see on El Cap systems, so there may be additional Corona-specific tuning opportunities; feedback on other settings to try is welcome! @tbennun @bvanessen