fix: moments TypeError: Cannot read properties of null#625
Merged
Conversation
Contributor
Author
|
经测试,不是 0a23422 造成的,似乎是历史遗留问题,halo主题商店版本也有这问题。 |
Owner
|
感谢反馈与提交的 PR。确实存在这个问题,但当前 PR 并没有能完全修复,还是会有重复的内容出现。 |
Owner
|
。重新测试了一下,重复的内容非当前 PR 所描述的问题。。即便关闭备案模式也会出现重复。 |
LIlGG
approved these changes
May 30, 2025
Owner
|
如果修改了需要 build 的文件,提交时需要把 build 后的资源文件一起提交。 因为主题属于直接下载 code 源码就可以运行在 Halo 中的状态,后续不会进行 actions 之类的操作。 |
Contributor
Author
哎呀!疏忽了,我是在我的master分支上修复的,代码CV过来没有测试就没有build,提交时也忘记build了。 这样的话,#629 也需要你bulid一下,麻烦了。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
当前 最新main分支 如果开启了备案模式(关闭评论),则瞬间页会出现第二页无法完整加载、加载重复的情况。
可能是 0a23422 造成的。
如图: