pref: change the repeater to use an array#646
Merged
Conversation
Added the 'valueOnly: true' property to several icon-related fields in settings.yaml to ensure only the icon value is stored. This change improves data consistency and handling for icon selection components.
There was a problem hiding this comment.
Pull request overview
This PR adapts the Sakura theme for Halo 2.22 by updating form components to use newer form kit types and improving the theme configuration structure.
Key Changes:
- Migrated all
checkboxform fields toswitchcomponents (38 instances) - Converted
repeaterfields toarrayfields withitemLabelsconfiguration for better UX (5 instances) - Replaced text-based icon fields with
iconifycomponents for better icon selection (3 instances) - Updated minimum Halo version requirement from 2.19.0 to 2.22
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| theme.yaml | Updated minimum required Halo version to 2.22 to match the new form component requirements |
| settings.yaml | Comprehensive migration of form components: checkbox→switch, repeater→array with itemLabels, text→iconify for icons, and text→attachment for image fields |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind improvement
What this PR does / why we need it:
适配 Halo 2.22
repeater改为使用array。iconify代替原有的图标字符串设置。switch代替原有的 checkbox。Does this PR introduce a user-facing change?