Logging Tweaks#113
Open
millercommamatt wants to merge 6 commits into
Open
Conversation
swapped `logger.basicConfig` for `logger.setLevel`
Swapped logging.basicConfig with setlevel
swapped logging.basicConfig with setLevel
changed to use setLevel only if basicConfig hadn't already be run
set to only use setLevel is basicConfig hadn't been run yet
only use setLevel if logger already has a handler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to fix what i think is an unintended bug for logging. In using flirpy in my code, I noticed that my logs were full of INFO level entries from flirpy despite the default logging level being WARNING. The reason for this is that in my code, I had already run
logging.basicConfig()and specified a logging level of INFO.logging.basicConfig()doesn't do anything if the logging object already has handlers. So, the log level setting for flirpy was being ignored. This PR makes it so that thesetLevelmethod is used when the logger already has handlers frombasicConfigbeing run. Otherwise,basicConfigis run.