Adding script for CNV's to master#17
Open
MaritIsKarel wants to merge 61 commits intomasterfrom
Open
Conversation
hgvs -> HGVS; genome build -> build; effect -> type.
It's based on the SNV file, with lots of code removed or disabled.
ifokkema
reviewed
Jan 22, 2026
Member
ifokkema
left a comment
ifokkema
left a comment
There was a problem hiding this comment.
Although the commit message does describe exactly what you did, it's not clear why you did this. Perhaps because you got tired of the messages during testing, and it should have been reverted later? In that case, it's best not to commit those changes, because it's then easy to forget to revert them, and now I'm wondering why they are still disabled.
ifokkema
requested changes
Jan 22, 2026
Member
ifokkema
left a comment
ifokkema
left a comment
There was a problem hiding this comment.
Thanks for this work! I have added some comments; some are just "FYI", while others are requests for small changes. Could you please address them? Then I'll have another look at the full code (now, I basically went through the commits, but I didn't review the complete scripts yet as a whole).
added 5 commits
April 16, 2026 16:23
…oudUMC HGVS descriptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging master with CNV script. So we're able to work with CNV's as well.