Add VocaDB source (unsynced)#222
Open
altalk23 wants to merge 2 commits intoLambada10:masterfrom
Open
Conversation
Author
an example output |
Author
|
also i did try to interweave the lyrics like 1 original 1 romanization but since they can be from different sources it wasnt reliable so i just scrapped that idea |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds VocaDB as a lyrics source (always unsynced as VocaDB does not have synced lyrics), uses both the translation and romanization options for providing those if needed
Translations for "Include translation" and "Include romanization" should probably changed from just netease to supported providers, but I'm not sure if I can change all of those languages