Skip to content

#43 Patch to fix intensity/altitude issue (auto max)#78

Open
Harvinator wants to merge 1 commit intoLeaflet:gh-pagesfrom
Harvinator:patch-1
Open

#43 Patch to fix intensity/altitude issue (auto max)#78
Harvinator wants to merge 1 commit intoLeaflet:gh-pagesfrom
Harvinator:patch-1

Conversation

@Harvinator
Copy link
Copy Markdown

This patch works by automatically setting the max as it changes on each zoom level as points get combined/separated.

You no longer need to manually set options.max

When calculating the max value it considers all points (even if they are off the screen). This way you always get the same results at a particular zoom level.

Thanks to @spacemansteve for pointing me in the right direction
ca1f430

This patch works by automatically setting the max as it changes on each zoom level as points get combined/separated.

You no longer need to manually set options.max

When calculating the max value it considers all points (even if they are off the screen). This way you always get the same results at a particular zoom level.

Thanks to @spacemansteve for pointing me in the right direction
ca1f430
@rrooij
Copy link
Copy Markdown

rrooij commented Jan 13, 2017

Any update on this? It would be nice to see it included.

The pull request works perfectly here.

@dchhetri0
Copy link
Copy Markdown

Bumping this, would appreciate some update here.

@nakiabrewer
Copy link
Copy Markdown

Any update on this? Need this working !

@galicianjorge
Copy link
Copy Markdown

I strongly suggest a disclaimer in the readme explaining this bug if it is not going to be be covered. This is a major bug

@ajhbh
Copy link
Copy Markdown

ajhbh commented Aug 13, 2018

This pull request is a must have! I am using it and it is much more intuitive to use the heatmaps when the intensity adjusts based on the current zoom. This really deserves to be merged, even after all this time.

@instantaphex
Copy link
Copy Markdown

It's been almost 3 and 1/2 years. Any plans on merging this in?

@tsafs
Copy link
Copy Markdown

tsafs commented Apr 22, 2020

At this point it might be worthwhile seeing if anyone else might want to manage this plugin whilst being active?

@adrianmxb
Copy link
Copy Markdown

adrianmxb commented Aug 9, 2021

Can this PR be approved?
Really unintuitive the way it is now.

@danielbeckera
Copy link
Copy Markdown

Please approve this PR, this is a major bug that needs to be fixed.

@yohanboniface
Copy link
Copy Markdown
Member

@mourner do you have a chance to have a quick check ?

I've tested it on uMap and it seems to have more friendly results. The implemented change seems logic to me, but I can't say I master the topic, so a check from you would help! And if it's good for you, I'm up for releasing :)

Thanks in advance, and take care, amigo!

yohanboniface added a commit to umap-project/umap that referenced this pull request Oct 5, 2023
Patch comes from Leaflet/Leaflet.heat#78

We'll remove it when this PR get merged and released.
vshie pushed a commit to vshie/pingSurvey that referenced this pull request Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.