Enable more lints by Nutomic · Pull Request #897 · LemmyNet/lemmy-js-client

Nutomic · 2026-03-16T14:18:55Z

No description provided.

Nutomic · 2026-03-16T14:19:42Z

+interface LemmyErrorDummy {
+  error: string;
+  message?: string;
+}


Had to add this because LemmyErrorType doesnt always have message, and so TS throws an error.

Isn't that accurate? shouldn't it be then json2.message ?? ""

Seems your right. Strange that there is no lint error.

But then you should be able to use LemmyErrorType ? its basically the same definition, every option has error but some have message?

No it throws this error:

src/http.ts:2941:15 - error TS2339: Property 'message' does not exist on type 'LemmyErrorType'. Property 'message' does not exist on type '{ error: "block_keyword_too_short"; }'. 2941 json2.message, ~~~~~~~ Found 1 error in src/http.ts:2941

Just make message in LemmyError optional, then you shouldn't need this dummy type.

Not working: Property 'message' does not exist on type '{ error: "block_keyword_too_short"; }'

Nutomic · 2026-03-16T14:22:11Z

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-empty-object-type */


Errors about the empty interface definitions below. It suggests using export type ListMediaI = ListMedia which passes lint, but not sure if its correct.

TSOA fails with type aliases and @queries decorator. So it wouldnt work.

But I have PR to fix that and then you can get rid of these below

lukeautry/tsoa#1841

Nutomic · 2026-03-17T09:53:37Z

I tried to revert the changes from #888 and #891 to see if lint catches them now. Strangely there are no errors thrown. Seems like something is still missing for proper linting.

dessalines · 2026-03-19T13:03:28Z

Probably needs prettier, and the woodpecker prettier lint should also check this file.

Done, wasnt running prettier in CI at all.

dessalines · 2026-03-19T13:03:53Z

-      "quote-props": 0,
-      "unicorn/filename-case": 0,
-    },
+    rules: {},


Maybe its not finding any because rules here is empty?

Removing this line makes no difference.

dessalines · 2026-03-19T13:04:36Z

      headers: this.#headers,
    });
-    return response.json();
+    return response.json() as ResponseType;


Surprised this needs an as cast

This one actually throws an error: Unsafe return of a value of type Promise @typescript-eslint/no-unsafe-return

dessalines · 2026-03-19T13:05:18Z

+interface LemmyErrorDummy {
+  error: string;
+  message?: string;
+}


Just make message in LemmyError optional, then you shouldn't need this dummy type.

dessalines

I tried messing with some things a little, but its probably fine as is. The as casting seems to be necessary for errors.

@Nutomic

* Update dependency lint-staged to v16.4.0 (#893) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency @redocly/cli to v2.21.1 (#892) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update pnpm to v10.32.1 (#894) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update typescript-eslint monorepo to v8.57.0 (#895) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Fix deleteMediaAdmin & deleteMedia wrong OpenAPI documentation #884 (#885) * Fix #887 adding missing async to endpoints (#888) * Fix #890 Some endpoints use 'object' instead of the actual type (#891) * Remove sleepless from codeowners. (#899) * Remove sleepless from codeowners. * Add @Nutomic as a code owner * Rename to importUserSettings & exportUserSettings (#900) * Update typescript-eslint monorepo to v8.57.1 (#901) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency @redocly/cli to v2.24.1 (#902) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency eslint to v10.1.0 (#903) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Enable more lints (#897) * Enable more lints (fixes #896) * review * format * Add nodeinfo (fixes #459) (#898) * Add nodeinfo (fixes #459) * review * ternary * route * fix routes, add superclass * fmt * update * 1.0.0-search.0 * fix tsoa --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Maarten Vercruysse <67873169+MV-GH@users.noreply.github.com> Co-authored-by: Dessalines <dessalines@users.noreply.github.com>

@Nutomic

* Adding list_persons, updating types from main * 1.0.0-search-optimizations-1.0 * Search optimizations 1 nutomic (#904) * Update dependency lint-staged to v16.4.0 (#893) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency @redocly/cli to v2.21.1 (#892) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update pnpm to v10.32.1 (#894) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update typescript-eslint monorepo to v8.57.0 (#895) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Fix deleteMediaAdmin & deleteMedia wrong OpenAPI documentation #884 (#885) * Fix #887 adding missing async to endpoints (#888) * Fix #890 Some endpoints use 'object' instead of the actual type (#891) * Remove sleepless from codeowners. (#899) * Remove sleepless from codeowners. * Add @Nutomic as a code owner * Rename to importUserSettings & exportUserSettings (#900) * Update typescript-eslint monorepo to v8.57.1 (#901) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency @redocly/cli to v2.24.1 (#902) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency eslint to v10.1.0 (#903) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Enable more lints (#897) * Enable more lints (fixes #896) * review * format * Add nodeinfo (fixes #459) (#898) * Add nodeinfo (fixes #459) * review * ternary * route * fix routes, add superclass * fmt * update * 1.0.0-search.0 * fix tsoa --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Maarten Vercruysse <67873169+MV-GH@users.noreply.github.com> Co-authored-by: Dessalines <dessalines@users.noreply.github.com> --------- Co-authored-by: Nutomic <me@nutomic.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Maarten Vercruysse <67873169+MV-GH@users.noreply.github.com>

Nutomic requested review from SleeplessOne1917 and dessalines as code owners March 16, 2026 14:18

Nutomic commented Mar 16, 2026

View reviewed changes

Nutomic force-pushed the enable-lints branch from e9a3e8f to ef57a3d Compare March 16, 2026 14:23

Enable more lints (fixes #896)

8a1c598

Nutomic force-pushed the enable-lints branch from ef57a3d to 8a1c598 Compare March 16, 2026 14:24

review

bfa5e06

dessalines reviewed Mar 19, 2026

View reviewed changes

Nutomic added 2 commits March 23, 2026 11:31

format

80d1067

Merge branch 'main' into enable-lints

047b1e8

Nutomic force-pushed the enable-lints branch from 6a94df1 to 047b1e8 Compare March 23, 2026 10:38

dessalines approved these changes Mar 23, 2026

View reviewed changes

Nutomic merged commit f351816 into main Mar 24, 2026
2 checks passed

		@@ -1,3 +1,4 @@
		/* eslint-disable @typescript-eslint/no-empty-object-type */

Uh oh!

Conversation

Nutomic commented Mar 16, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Nutomic commented Mar 17, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Nutomic Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dessalines left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Nutomic Mar 23, 2026 •

edited

Loading