ThunderFX: Modify GraphModule in-place - #2399
Merged
shino16 merged 8 commits intoAug 28, 2025
Merged
Conversation
kshitij12345
approved these changes
Aug 6, 2025
kshitij12345
left a comment
kshitij12345
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thanks @shino16
kiya00
reviewed
Aug 6, 2025
kiya00
approved these changes
Aug 6, 2025
…optionally save fusion region and traces (Lightning-AI#2232) While exploring the split reasons and observing changes in traces and fusion areas when adding missing fallback operators, I realized that having an API to save all repro scripts, with options to also save fusion graphs or traces to files, would be helpful. Before this PR, the user had to do the iteration and save manually.
shino16
force-pushed
the
do-not-return-deepcopy-of-GraphModule
branch
from
August 7, 2025 06:37
3bffc0b to
64e9426
Compare
t-vi
approved these changes
Aug 22, 2025
t-vi
left a comment
t-vi
left a comment
Collaborator
There was a problem hiding this comment.
Thank you @shino16 @kshitij12345 @kiya00
Collaborator
|
Hi @shino16 , Tom has stamped, let's rebase and merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1821.
Changes
ThunderFXnow mutates the given GraphModule itself.remove_empty_autocast(gm)is changed in the same way.See @kiya00's analysis on why this resolves #1821.
Further step
As @kshitij12345 has pointed out in his comment, the existing deepcopy of the GraphModules for constructing
subgraph_infoshould be avoided. This PR changes the way we handle the GraphModule argument but does not eliminate copying.