remove setitem_ output manipulation - #2427
Merged
Merged
Conversation
crcrpar
approved these changes
Aug 14, 2025
Collaborator
Author
|
@t-vi This PR is simply removing some now outdated code. Could you take a look? |
t-vi
approved these changes
Aug 21, 2025
t-vi
left a comment
t-vi
left a comment
Collaborator
There was a problem hiding this comment.
Thank you @beverlylytle @crcrpar
t-vi
enabled auto-merge (squash)
August 21, 2025 13:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #2397 it is no longer necessary for update_aliases to add the output to
setitem_, not that it was ever a good idea.