Skip to content

Preserve source locations in visitor transforms #2834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mukeshr06 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Preserve source locations in visitor transforms #2834

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions thunder/core/transforms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,8 @@ def visitor_transform(trace_from: Trace, visit: Callable, *, provenance: None |
scope = []
trc.push_scope(scope)

# Attribute recorded operations, including subsymbols, to the visited operation.
trc.set_current_source_location(bsym.source_filename, bsym.source_positions)
visit_type = visit(bsym)

if visit_type is VISIT_TYPE.INSERT_AFTER:
Expand All @@ -409,6 +411,7 @@ def visitor_transform(trace_from: Trace, visit: Callable, *, provenance: None |
trc.bound_symbols.append(bsym)

finally:
trc.set_current_source_location(None, None)
# Restores the trc's scope
trc.pop_scope()

Expand Down