Conversation
Explain Falcon Chinese tokenization, unchanged embedding parameter counts, and the requirements and LoRA limitations of intentional vocabulary expansion. Refs Lightning-AI#225.
mukeshr06
requested review from
andyland,
k223kim,
lianakoleva and
t-vi
as code owners
September 22, 2026 05:49
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #225 by adding a focused "Finetuning on a new language" section to the existing fine-tuning guide.
This is documentation-only. It does not introduce an automatic resizing API or change training behavior.
Validation
pytest --check-links tutorials/finetune.md --check-links-ignore "http*": 5 passed.codespell tutorials/finetune.md: passed.git diff --check: passed.tiiuae/falcon-7b/tokenizer.jsonwith Hugging Facetokenizers; verified exact encode/decode round-trips for Simplified Chinese, Traditional Chinese, and mixed English/Chinese samples, in-range token IDs, and an unchanged 65,024-token vocabulary.No model weights were downloaded and no training or full test suite was run.